Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Crashes sometimes occur in case of cancellation when several requests are pending #41

Closed
englebertnicolas opened this issue Nov 12, 2017 · 1 comment

Comments

@englebertnicolas
Copy link

Crashes sometimes occur in case of cancellation when several requests are pending.

Following update corrects the issue:
In the Speak(...) function (TextToSpeech.Plugin.iOS/TextToSpeech.cs line 50), just after:
await semaphore.WaitAsync(cancelToken);
Add:
cancelToken.ThrowIfCancellationRequested();

(Before calling: await SpeakUtterance(speechUtterance, cancelToken);)

Bug Information

Version Number of Plugin: 3.0.1
Device Tested On: iPhone 6 (11.1)
Simulator Tested On:
Version of VS: 2015 (14.0.25431.01 update 3)
Version of Xamarin: 4.7.10.33
Versions of other things you are using:

Steps to reproduce the Behavior

Expected Behavior

Actual Behavior

Code snippet

Screenshotst

@prashantvc
Copy link
Collaborator

Crashes sometimes occur in case of cancellation when several requests are pending.

How often does this happen? Could you share crash log? It will help us to troubleshoot the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants