Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #30

Closed
eliocamp opened this issue Dec 1, 2022 · 1 comment
Closed

Add tests #30

eliocamp opened this issue Dec 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@eliocamp
Copy link

eliocamp commented Dec 1, 2022

Currently there are no test in the package and many examples are not run. covr::package_coverage() reports 0.15% coverage. I think that adding tests to increase coverage to at least 60% is necessary before publication (ideally it should be higher, but testing ggplot2 extensions can be hard since it involves a lot of visual testing; even ggplot2 barely reaches 80%).

Check the vdiffr package for a guide on how to use visual regression testing.

@jamesotto852 jamesotto852 added the enhancement New feature or request label Feb 10, 2023
@jamesotto852
Copy link
Owner

We have implemented many unit tests in #31, covr::package_coverage() now reports 95.05% coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants