Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Randomness and reproducibility #22

Open
apmcleod opened this issue Aug 22, 2019 · 3 comments
Open

Ensure Randomness and reproducibility #22

apmcleod opened this issue Aug 22, 2019 · 3 comments
Milestone

Comments

@apmcleod
Copy link
Collaborator

Some types of randomness aren't guaranteed to be OS independent.

Also, we may want to use a numpy RandomState rather than seeds, but probably not.

@apmcleod apmcleod added this to the Dataset v1.0 Release milestone Oct 16, 2019
@apmcleod
Copy link
Collaborator Author

apmcleod commented Nov 1, 2019

Given that we will release the official ACME as a zipfile (or something), I don't think this is necessarily important. If people have slightly different random seeds, it's probably not a big deal.

@apmcleod apmcleod mentioned this issue Nov 1, 2019
Merged
@JamesOwers
Copy link
Owner

It's a shame not to be able to ensure full reproducibility given some set of parameters for the make_dataset.py script...but I don't think it's priority for the reason you give. Let's kick this for now.

@apmcleod
Copy link
Collaborator Author

Agreed. I'll remove the milestone.

@apmcleod apmcleod removed this from the Dataset v1.0 Release milestone Nov 12, 2019
@JamesOwers JamesOwers changed the title Ensure Randomness Ensure Randomness and reproducibility Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants