Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike notifications not always sent if dismissed a short time ago #744

Open
jamespizzurro opened this issue Dec 10, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@jamespizzurro
Copy link
Owner

jamespizzurro commented Dec 10, 2023

At least for me in Chrome (119.0.6045.200) on Windows 11 (Home, 22H2), when I visit a website and get notified about a strike, if I dismiss that notification, I stop getting notifications about that strike for a while. This may be behavior enforced by the browser and/or operating system I'm using, but I noticed that, after a few minutes, something happens and I'll get another notification about that strike if I visit the site that triggered the original notification again, even if that means just switching to an existing tab with it still open.

It seems like notifications are clearing in such a way that notifications.getAll continues to return those notifications for a short time after they've been dismissed. One way for us to explicitly handle this would seemingly be to use notifications.onClosed to clear notifications using notifications.clear, which would then hopefully prevent dismissed notifications from being returned by notifications.getAll next time it's invoked.

@jamespizzurro jamespizzurro added the bug Something isn't working label Dec 10, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant