You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
The current approach to abstracting the WebSocket connection, commandClient, is poorly designed. Due to its Pub/Sub nature, consuming it across the codebase results in potential race conditions.
Proposed replacement:
The new command client uses a Promise-based API, so consumers are more directly in control of invocation
Promises will return their own EventEmitter instances, so that Term4All can still interact with long-lived processes. This will also make subscription cleanup easier
The text was updated successfully, but these errors were encountered:
When I run this app the first time it works fine, but when I try to refresh the page, the back-end gives me the 'not opened' error.(see below) I'm guessing this issue you brought up is related to the error I am encountering? But I have a hard time understand why it is poorly designed and your proposed replacement. Could you help me to understand? I am new to web programming. Thanks in advance.
The current approach to abstracting the
WebSocket
connection,commandClient
, is poorly designed. Due to its Pub/Sub nature, consuming it across the codebase results in potential race conditions.Proposed replacement:
Promise
-based API, so consumers are more directly in control of invocationPromise
s will return their ownEventEmitter
instances, so that Term4All can still interact with long-lived processes. This will also make subscription cleanup easierThe text was updated successfully, but these errors were encountered: