Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamToObservable may not be handling promise rejections correctly #12

Open
Aghassi opened this issue May 7, 2018 · 0 comments · May be fixed by SamVerschueren/stream-to-observable#3 or #13
Open

Comments

@Aghassi
Copy link

Aghassi commented May 7, 2018

Hello 😄

I'm opening this issue because @sindresorhus pointed me here after a long conversation on twitter. Essentially, I wanted to mimic some function that exists in np. I've made a demo repo here https://github.com/Aghassi/promise-observables

Essentially, if you run node transpiled.js, you will see UnhandledPromiseWarning on failure. I've tried a number of things to catch properly, but have been unsuccessful. Could it have something to do with how this repo rejects promises? I wanted to get the discussion going before I was able to possibily contribute because of other priorities I have running at the moment.

@Aghassi Aghassi changed the title streamToObservable may not be handling promise rejections correct streamToObservable may not be handling promise rejections correctly May 7, 2018
teppeis added a commit to teppeis/stream-to-observable that referenced this issue May 5, 2019
teppeis added a commit to teppeis/stream-to-observable that referenced this issue May 5, 2019
@teppeis teppeis linked a pull request May 5, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant