Merge pull request #115 from Wolphin-project/master

use full path in RequiredFieldValidationError
jpmckinney · Oct 10, 2017 · 96cabe2 · 96cabe2
2 parents ae13e5d + 816d7cb
commit 96cabe2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/validictory/tests/test_other.py b/validictory/tests/test_other.py
@@ -63,6 +63,18 @@ def test(self):
             self.fail("No Exception")
 
 
+def test_deep_required_error():
+    schema = {'type': 'object', 'properties': {'foo': {'type': 'object',
+              'properties': {'bar': {'type': 'integer', 'required': 'true'}}}}}
+    data = {'foo': {'baz': 3}}
+    try:
+        validictory.validate(data, schema)
+    except validictory.validator.RequiredFieldValidationError as e:
+        estr = str(e)
+        assert 'foo' in estr
+        assert 'bar' in estr
+
+
 def test_deep_error():
     schema = {'type': 'object', 'properties': {'foo': {'type': 'object', 'properties':
                                                        {'bar': {'type': 'array', 'items':

diff --git a/validictory/validator.py b/validictory/validator.py
@@ -333,7 +333,7 @@ def validate_required(self, x, fieldname, schema, path, required):
         ''' Validates that the given field is present if required is True '''
         # Make sure the field is present
         if fieldname not in x and required:
-            self._error("Required field '{fieldname}' is missing", None, fieldname, path=path,
+            self._error("Required field '{fieldname}' is missing", None, path, path=path,
                         exctype=RequiredFieldValidationError)
 
     def validate_blank(self, x, fieldname, schema, path, blank=False):