Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New" gmail breaks plugin #17

Open
smithygreg opened this issue Oct 15, 2018 · 0 comments
Open

"New" gmail breaks plugin #17

smithygreg opened this issue Oct 15, 2018 · 0 comments

Comments

@smithygreg
Copy link

smithygreg commented Oct 15, 2018

Not sure if anyone is maintaining this or interested, but in case someone comes across the same issue I have...

The "new" gmail interface that is being phased in in mid to late 2018 breaks this plugin.
The specific issue happens in line 243 of gmailr.js

var win = top.document.getElementById("js_frame").contentDocument.defaultView;

Gmail no longer includes the iframe with this script. The script itself is included in the document itself.

This seems to fix the issue.
try{ win = top.document.getElementById("js_frame").contentDocument.defaultView; //Old Gmail } catch(e){ win = window; //New Gmail }

Be aware that there are a whole host of other issues that cropped up with this "new" interface...One of which being the format of the data that is sent out (It is no longer a url string...It is now a json object).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant