Add "location" query method to bucket

[fishcharlie]

It looks like the get bucket route is prepared to handle location in the future.

s3rver/lib/routes.js

Lines 71 to 101 in de7c5a3

	.get("/:bucket", bucketCtrl.bucketExists, ctx => {
	switch (ctx.params.queryMethod) {
	case undefined:
	return bucketCtrl.getBucket(ctx);
	case "cors":
	return bucketCtrl.getBucketCors(ctx);
	case "website":
	return bucketCtrl.getBucketWebsite(ctx);
	case "acl":
	case "analytics":
	case "encryption":
	case "inventory":
	case "lifecycle":
	case "location":
	case "logging":
	case "metrics":
	case "notification":
	case "object-lock":
	case "policyStatus":
	case "publicAccessBlock":
	case "replication":
	case "requestPayment":
	case "tagging":
	case "uploads":
	case "versioning":
	ctx.throw(501);
	break;
	default:
	ctx.state.methodIsNotAllowed = true;
	}
	})

But in the bucket methods location isn't listed.

s3rver/lib/controllers/bucket.js

Lines 38 to 58 in de7c5a3

	exports.METHODS = [
	"acl",
	"analytics",
	"cors",
	"delete",
	"encryption",
	"inventory",
	"lifecycle",
	"metrics",
	"notification",
	"object-lock",
	"policy",
	"policyStatus",
	"publicAccessBlock",
	"replication",
	"requestPayment",
	"tagging",
	"uploads",
	"versions",
	"website"
	];

Is there a reason for this? It seems like a bug to me, but not 100% sure.

[kherock]

Yeah that looks like a very minor bug (S3rver would report MethodNotAllowed instead of NotImplemented). Did you have a use for location?

[fishcharlie]

@kherock No use for it. Just trying to understand the code base and make sure I'm understanding it correctly.