-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests-mock v1.12.0 incorrectly installs for python 2 breaking pipelines #254
Comments
Putting in another vote for this. I've seen this a lot recently where a project will drop PY2 support (fairly I must say) but doesn't properly reflect that in the metadata for the package and other projects with dependencies that are not explicitly pinned will start breaking. In our case, we have to support 2.7, at least in our build pipelines. We use If someone who works on requests-mock is here, would it be possible to yank 1.12.0 and republish with |
Ah, you never get this right for everyone. I spent a lot of time looking to whether i needed to bump a major version for dropping py2 and was eventually convinced it was normal to not. Having said that, you're right. I didn't see |
I am blocked from uploading a new package whilst pypi is locked. I'll restart the job a bit later. |
No problem, appreciate the quick response |
1.12.1 published. Please confirm it fixes the issue. |
@jamielennox Yes that should resolve it, but you need to yank 1.12.0 |
sure - done. |
@jamielennox Thank you! |
Hello, the recent version released of requests-mock 1.12.0 incorrectly installs on python 2 when it is only supported on python 3 and above.
This is causing a break in ci / cd pipeline.
Metadata of the package should be set to be downloadable only for python 3
Quick solution for now is to pin to version < 1.12.0 but can this be rectified?
The text was updated successfully, but these errors were encountered: