-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material design #26
Comments
latest push has added a picture with parallax scroll to the top of show activity. the remaining thing to do here is change how the action bar suddenly turns from transparent to opaque. we should animate filling the gap (rather than a instant change or fading the colour) like in the IO 2014 app. overall I really like the new ShowActivity though. I definitely think EpisodeActivity should get the same treatment. |
Loving the new look for ShowActivity, but how is EpisodeActivity going to get the same one? Will every episode have the same image? Because that seems strange to me. |
thetvdb provides a screenshot for most most episodes which we can use. |
Oh, well in that case I don't see any problems. |
I've pushed a change which uses a dark purple theme with a teal accent. The shade of purple wasn't actually on the material colour palette but I prefer it to the ones they did have. I think this looks quite nice, but I'm open to suggestions of other colour themes. |
I'm sorry to say I'm not a fan of the latest look. Since the app already gets a lot of color from the banner and header images, as well as the progress bar and check boxes, adding another color feels like a bit too much in my opinion. I was a fan of the grey action bar, but if you want to incorporate purple in the design, may I suggest dropping the teal and replacing it with one of the purples from the material design color pallet? |
I agree it doesn't look as good. and this was the best i came up with after trying many colour combinations, because google want apps to use a lot if colour. but I think you're right- there's plenty of colour from the images. I'll probably switch it back. |
Couple more items checked off. Still lots of room for improvement though! |
List of things to make the app more materially:
a floating action button. I tried this and it seems weird. It also goes against the guidelines. Instead I've just moved the checkbox out of the action bar and in to the fragment content.These are just a few thoughts off the top of my head. If anybody has any more ideas then please leave a comment.
The text was updated successfully, but these errors were encountered: