Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material design #26

Open
5 of 6 tasks
jamienicol opened this issue Jan 2, 2015 · 8 comments
Open
5 of 6 tasks

Material design #26

jamienicol opened this issue Jan 2, 2015 · 8 comments

Comments

@jamienicol
Copy link
Owner

List of things to make the app more materially:

  • Pick a colour scheme. See here: http://www.google.co.uk/design/spec/style/color.html
  • Display a big picture with parallax scroll and transparent action bar at top of ShowActivity.
    • Animate change between transparent and opaque action bar when page is scrolled up far enough.
  • Same thing for EpisodeActivity too.
  • Change the "watched" checkbox in EpisodeDetailsFragment's action bar to be a floating action button. I tried this and it seems weird. It also goes against the guidelines. Instead I've just moved the checkbox out of the action bar and in to the fragment content.
  • Use RecyclerView for shows list. I think this will give us animations when items are added/removed (changing the filter). But even if it doesn't it'll be an under-the-hood improvement.

These are just a few thoughts off the top of my head. If anybody has any more ideas then please leave a comment.

@jamienicol
Copy link
Owner Author

latest push has added a picture with parallax scroll to the top of show activity. the remaining thing to do here is change how the action bar suddenly turns from transparent to opaque. we should animate filling the gap (rather than a instant change or fading the colour) like in the IO 2014 app.

overall I really like the new ShowActivity though. I definitely think EpisodeActivity should get the same treatment.

@ahstro
Copy link
Contributor

ahstro commented Jan 10, 2015

Loving the new look for ShowActivity, but how is EpisodeActivity going to get the same one? Will every episode have the same image? Because that seems strange to me.

@jamienicol
Copy link
Owner Author

thetvdb provides a screenshot for most most episodes which we can use.

@ahstro
Copy link
Contributor

ahstro commented Jan 12, 2015

Oh, well in that case I don't see any problems.

@jamienicol
Copy link
Owner Author

I've pushed a change which uses a dark purple theme with a teal accent. The shade of purple wasn't actually on the material colour palette but I prefer it to the ones they did have.

I think this looks quite nice, but I'm open to suggestions of other colour themes.

@ahstro
Copy link
Contributor

ahstro commented Jan 19, 2015

I'm sorry to say I'm not a fan of the latest look. Since the app already gets a lot of color from the banner and header images, as well as the progress bar and check boxes, adding another color feels like a bit too much in my opinion.

I was a fan of the grey action bar, but if you want to incorporate purple in the design, may I suggest dropping the teal and replacing it with one of the purples from the material design color pallet?

@jamienicol
Copy link
Owner Author

I agree it doesn't look as good. and this was the best i came up with after trying many colour combinations, because google want apps to use a lot if colour.

but I think you're right- there's plenty of colour from the images. I'll probably switch it back.

@jamienicol
Copy link
Owner Author

Couple more items checked off. Still lots of room for improvement though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants