Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis? #7

Closed
jamwaffles opened this issue Mar 19, 2018 · 5 comments
Closed

Travis? #7

jamwaffles opened this issue Mar 19, 2018 · 5 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@jamwaffles
Copy link
Collaborator

We should have some kind of CI process!

At minimum, right now I think it should:

  • Run rustfmt and fail if any code changes to keep code clean and consistent
  • Run cargo test to make sure the examples build*

*because there aren't any tests at the moment...

Anything else?

@jamwaffles jamwaffles added help wanted Extra attention is needed question Further information is requested labels Mar 19, 2018
@scowcron
Copy link
Collaborator

scowcron commented Mar 19, 2018

Docs would be nice. take a look at cargo doc-upload. I did some fiddling with it here:

https://github.com/EdgewaterDevelopment/rust-ssd1306/blob/master/.travis.yml

It only uploads docs when it sees changes on master.

@jamwaffles
Copy link
Collaborator Author

I like that. Is there a way to get it to upload to docs.rs? I can't decide whether using docs.rs or GitHub pages is better at the moment.

@scowcron
Copy link
Collaborator

I've never worked with docs.rs, from what I read doc-upload just updates and pushes to your gh-pages branch. the other thing that might be worth looking at is japaric's trust repo, I didn't really dig into it, but it looks kind of nifty.

@jamwaffles
Copy link
Collaborator Author

Hmm, at first glance it looks like overkill for this crate at the moment at least. Tbf, pushing to a gh-pages branch gives us more control anyway so it's not such a bad thing.

@jamwaffles jamwaffles mentioned this issue Mar 19, 2018
jamwaffles added a commit that referenced this issue Mar 20, 2018
Precursor to getting #7 working. Any examples that use embedded_graphics
now need to add `--features graphics` to their run commands to work.

There must be a better way than using all those `cfg()`s.
jamwaffles added a commit that referenced this issue Mar 20, 2018
Precursor to getting #7 working. Any examples that use embedded_graphics
now need to add `--features graphics` to their run commands to work.

There must be a better way than using all those `cfg()`s.

Fixes #4
@jamwaffles
Copy link
Collaborator Author

Closed by #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants