Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #8

Closed
jamwaffles opened this issue Mar 19, 2018 · 4 comments · Fixed by #51
Closed

Documentation #8

jamwaffles opened this issue Mar 19, 2018 · 4 comments · Fixed by #51
Labels
good first issue Good for newcomers
Milestone

Comments

@jamwaffles
Copy link
Collaborator

Uncomment this line and add some basic docs for everything.

@jamwaffles jamwaffles added the good first issue Good for newcomers label Mar 19, 2018
@jamwaffles
Copy link
Collaborator Author

Relevant discussion in #7

@jamwaffles
Copy link
Collaborator Author

jamwaffles commented Apr 8, 2018

Some specific things I've noticed in the rendered docs:

  • There should be a platform-agnostic example on the docs landing page with a graphics example, probably exercising all bits of the embedded_graphics API (triangle, square, circle, text, image). This will get updated with a following char mode example when TerminalMode #27 is ready. A link to a runnable example demonstrating the same for each display mode would be good too.
  • To extend the previous point, there should be an explanation of the concept of display modes; this driver can't be used without choosing one!
  • There should be better links between types/other language constructs in the docs
  • Readme:
    • The image needs to go on a diet. It's huge at the moment.
    • graphics is on by default and no longer optional so should be de-listed
    • A complete copypasta for stm32f103 would be good
    • Link to examples directory
  • The re-exports list needs an audit. This is related to Add a prelude #5 so can probably be fixed over there
  • Should there be a description of how all the modules fit together?
  • builder needs a couple of examples. I suggest:
    • A default/basic one that just sets up a display in graphics mode with SPI
    • One that exercises as many of the builder options as possible that changes the display size, rotation and I2C address in I2C mode.
  • Rotate180 doesn't actually flip the display, it just (uh...) rotates it.
  • interface should mention the ridiculous and not so ridiculous types required by RTFM apps.
  • Each mode should have an explanation of what it does. Also worth mentioning that RawMode shouldn't be directly used and is only a helper for the builder.
  • borrow_iface_mut could use a short usage example. Method was removed in Features/refactorcommands #49.
  • Make sure each module has a more-than-one-line description of what it does, preferably with a code example.

@therealprof
Copy link
Collaborator

borrow_iface_mut could use a short usage example.

Actually that should go away and the "DisplayProperties" (or whatever the name will end up to be in the end) should provide proper methods to change configuration and send data.

@therealprof
Copy link
Collaborator

Cf. #49

@jamwaffles jamwaffles mentioned this issue Apr 9, 2018
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants