Move reset to DisplayModeTrait #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality is common, so the implementation can be as well.
jamwaffles
requested changes
Jun 12, 2020
There was a problem hiding this comment.
Looks good overall, but I disagree about the changelog. It's sort of-kinda-not breaking, but might break things for people that don't like using preludes. I'd suggest adding something like the following to the Changed section:
- [#126](https://github.com/jamwaffles/ssd1306/pull/126) Moved `reset` method to `DisplayModeTrait`. If the prelude is not used, add either `use ssd1306::prelude::*` or `ssd1306::mode::displaymode::DisplayModeTrait` to your imports.
|
Fair enough. I also marked it as breaking |
jamwaffles
requested changes
Jun 12, 2020
Co-authored-by: James Waples <james@wapl.es>
jamwaffles
approved these changes
Jun 12, 2020
|
No worries, thanks for accepting my contributions :) |
|
Any time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality is common, so the implementation can be as well.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
Just a bit of cleanup. Should be backwards compatible since the trait is in the prelude. I don't think there should be a changelog entry for this one.