Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default save location for tokens not remembered #19

Closed
JamzTheMan opened this issue Sep 17, 2017 · 7 comments
Closed

Default save location for tokens not remembered #19

JamzTheMan opened this issue Sep 17, 2017 · 7 comments
Labels
bug help wanted MapTool issue relates to MapTool code vs 3rd party libs
Projects
1.4.4.0 1.5.x.x Fixes & Enhancements
Milestone
1.4.4.0

Comments

@JamzTheMan
Copy link
Owner

JamzTheMan commented Sep 17, 2017 •
edited
Loading

When saving token and token images, file save dialog defaults to app directory and should default to last save location. Also, changing save 'type" resets directory location.
@JamzTheMan JamzTheMan self-assigned this Sep 17, 2017
@JamzTheMan JamzTheMan added bug MapTool issue relates to MapTool code vs 3rd party libs investigating researching if issue is valid and/or reasonable labels Sep 17, 2017
@JamzTheMan JamzTheMan added this to To Do in 1.4.4.0 Sep 17, 2017
@JamzTheMan JamzTheMan removed the investigating researching if issue is valid and/or reasonable label Sep 17, 2017
@JamzTheMan
Copy link
Owner Author

Fixed so token saving now defaults to last file save location and saves the same. Also, changing "file filter types" no longer changes directory, only the default name.

@JamzTheMan JamzTheMan added the fixed bug fix is committed for next release label Nov 23, 2017
JamzTheMan added a commit that referenced this issue Nov 23, 2017
@JamzTheMan
Bug fix for Issue #19
b8212c6 
19: Default save location for tokens not remembered 

Task-Url: #19

Signed-off-by: Jamz <Jamz@Nerps.net>
@JamzTheMan JamzTheMan moved this from To Do to Done in 1.4.4.0 Nov 23, 2017
@JamzTheMan JamzTheMan added this to the 1.4.0.0 milestone Nov 25, 2017
@Sereptus
Copy link

Sereptus commented Dec 1, 2017

I'm sorry James but I've downloaded the latest versions every update and I still continue to have this issue. Hate to be a pest but like I said, I have the latest version. 1.4.20 from here. Am I missing something? :?

@JamzTheMan
Copy link
Owner Author

It's fixed for next release, 1.4.4.0. I have a beta out but official release will come out soon...

@Sereptus
Copy link

Sereptus commented Dec 1, 2017

Ooooh, ok. Thanks for all your hard work and dedication! I'm just setting up for Storm Kings Thunder (D&D 5E) so I'll hold off on doing the entire Monster Manual from 5E until the new release. I also find myself becoming very passionate about attempting to change the sight code to where a token that, for example, has Darkvision 30 ft to change the vision seen on screen as something like 22 feet of vision and then sort of a soft fog for the last 8 feet. Sorry if I'm unclear with that but I've been at work for 14 hours and am stubbornly staying awake. Anyway, I'd love to get a compile of Maptool so I could sort through the bits and pieces and screw around with it. Is this possible? Maybe your NERPS compile? I dunno, maybe I'll get some sleep and get back to ya. Thanks again.

@JamzTheMan
Copy link
Owner Author

Are you taking about changing within maptool or in the Java code?

And if you want, a beta is up, just go to releases on GitHub.

@JamzTheMan JamzTheMan reopened this Dec 6, 2017
@JamzTheMan
Copy link
Owner Author

OK, so this is partially fixed. It's using the saved location for files (where you last saved campaign/exported maps, but when saving tokens, it's not updating/saving the new location...

@JamzTheMan JamzTheMan added in progress issue is being worked and removed fixed bug fix is committed for next release labels Dec 6, 2017
@JamzTheMan JamzTheMan added fixed bug fix is committed for next release in progress issue is being worked and removed in progress issue is being worked fixed bug fix is committed for next release labels Mar 20, 2018
@JamzTheMan
Copy link
Owner Author

Low hanging fruit... if someone wants to knock this one out...

@JamzTheMan JamzTheMan removed their assignment Sep 29, 2018
@JamzTheMan JamzTheMan removed the in progress issue is being worked label Sep 29, 2018
@JamzTheMan JamzTheMan added this to Medium priority in 1.5.x.x Fixes & Enhancements Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted MapTool issue relates to MapTool code vs 3rd party libs
Projects
No open projects
1.4.4.0
  
Done
1.5.x.x Fixes & Enhancements
  
Medium priority
Milestone
1.4.4.0
Development

No branches or pull requests
2 participants
@Sereptus @JamzTheMan