Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build marked as failed when multiple builds are in progress #15

Closed
jamestelfer opened this issue Oct 7, 2013 · 3 comments
Closed

Build marked as failed when multiple builds are in progress #15

jamestelfer opened this issue Oct 7, 2013 · 3 comments
Assignees

Comments

@jamestelfer
Copy link

When a build is executing concurrently on different commits, the build is marked as a failure. I believe this is because the code for JobView.lastResult only gets the previous result if the build is running; I think it needs to get the status of the previous completed build instead.

This is related to the improvements from #9 I think, but it's still distinct from them.

I'm sorry I haven't attached a pull request, but I don't have a Java build environment. Thanks for your efforts with this plugin so far.

@jan-molak
Copy link
Member

Hi James and thanks for your feedback!
I'll need to look into this one a bit more in depth, since there are several things I need to consider in order to support concurrent builds. For example: how should the progress be represented?
I've got a couple of ideas on how to address the issue you've raised as well as #13 at the same time, so stay tuned :)

Jan

@jamestelfer
Copy link
Author

To be honest, while I agree with your thinking, at the moment on my infrastructure the build is often appearing to be broken. Is there any possibility of a quick-fix release, with more thorough functionality coming later?

I realise your time is valuable however, and I can imagine that an interim release might not be worth your time.

Cheers,
JT

@jamestelfer
Copy link
Author

Many thanks, Jan, this is greatly appreciated. This is already a great plugin; I'm looking forward to seeing where you go with it.

@ghost ghost assigned jan-molak Nov 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants