Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to Extend Defaults #7

Closed
Fleshgrinder opened this issue Dec 20, 2021 · 2 comments
Closed

Ability to Extend Defaults #7

Fleshgrinder opened this issue Dec 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Fleshgrinder
Copy link

The plugin is currently written in a way that both the inclusions and exclusions cannot be kept and extended. Instead one has to redefine them entirely if an additional pattern is to be added. This is because the qualifiers are hardcoded in the plugin, and applied only if the list is not empty. It would be better to switch to Gradle's property API in the extension, with the defaults already added. This way users can decide if they want to add or set.

I'm happy to provide a patch, but once I'm back from holiday's in January. 😉
@Fleshgrinder Fleshgrinder mentioned this issue Dec 20, 2021
Closed
@janderssonse
Copy link
Owner

janderssonse commented Dec 21, 2021 •
edited
Loading

Thanks for the input, good suggestions. I'll have a look at that after the holidays:)

@janderssonse janderssonse added the enhancement New feature or request label Dec 21, 2021
@janderssonse
Copy link
Owner

Had a long holiday:) I implemented this partially in 0.1.12.
Lazy properties, that is set default if no options given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fleshgrinder @janderssonse