Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the row collection scrubbing in Fast Forward mode #83

Closed
jandrew opened this issue Sep 23, 2015 · 1 comment
Closed

Lower the row collection scrubbing in Fast Forward mode #83

jandrew opened this issue Sep 23, 2015 · 1 comment
Assignees

Comments

@jandrew
Copy link
Owner

jandrew commented Sep 23, 2015

This is valuable when a person wants to read the middle/end of the sheet only.

The change would be applied to the ~::WorksheetToRow module

This could be accomplished with two things. First only reading the row number when cycling through the sheet and storing the last and current row informally until the desired row position is reached and then scrub and store both prior and current rows as Row objects. Second, build a row to position lookup JIT so that jumping around in the sheet would be marginally less painful after the first parse that included the jump point.

@jandrew jandrew self-assigned this Sep 23, 2015
@jandrew jandrew added the Speed label Sep 23, 2015
@jandrew
Copy link
Owner Author

jandrew commented Sep 24, 2015

After contemplating this implementation maybe not storing the last row at all just the last row number is best. I'm not sure how often people jump back and forth between two rows vs wanting to fast forward to the middle of a sheet. The second case seems more likely and in my personal usage the more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant