Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffi_generated_types not exposed, breaking Async_ssl linking #2

Closed
avsm opened this issue Mar 21, 2015 · 4 comments · Fixed by ocaml/opam-repository#3827
Closed

Ffi_generated_types not exposed, breaking Async_ssl linking #2

avsm opened this issue Mar 21, 2015 · 4 comments · Fixed by ocaml/opam-repository#3827

Comments

@avsm
Copy link

avsm commented Mar 21, 2015

The module is not included in the Async_ssl pack, so linking against Async_ssl always fails at link time.

Fixed it by including Ffi_generated_types in the _oasis file, and adding

"lib/ffi_generated_types.cmx": for-pack(Async_ssl)

to the _tags file.

@avsm
Copy link
Author

avsm commented Mar 23, 2015

Can't really workaround this one easily aside from marking the whole package broken. Is there an ETA on a fix or should I do that ?

@trefis
Copy link
Contributor

trefis commented Mar 23, 2015

I'll update the package and send a PR on opam later today.
Sorry for the delay!

@avsm
Copy link
Author

avsm commented Mar 23, 2015

That's great, thanks -- just knowing a rough eta is helpful

@trefis trefis closed this as completed in 624aed0 Mar 23, 2015
@trefis
Copy link
Contributor

trefis commented Mar 23, 2015

Thanks for the fix!
I'm actually holding off on the opam-package update though because I'd like to resolve #3 before doing another minor release.
Hopefully this can be resolved today/tomorrow, otherwise I'll do a minor release with only the fix of this issue tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants