Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing documentation #153

Open
jrootham opened this issue Jul 16, 2022 · 3 comments
Open

Missing documentation #153

jrootham opened this issue Jul 16, 2022 · 3 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@jrootham
Copy link

The method In_channel.read_all (and possibly others) is/are not documented in the linked documentation.
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Jul 20, 2022
@bcc32
Copy link
Member

bcc32 commented Jul 25, 2022

Hi @jrootham, In_channel.read_all is defined and documented in the Stdio library, and then included in Core from there. I would expect its documentation to be carried over as well.

Can you link to the documentation page you are looking at that shows missing documentation for that function?

@tdelvecchio-jsc
Copy link

Closing this for now; feel free to reopen it if you have a link to where the documentation is missing.

@ildar
Copy link

ildar commented Jun 8, 2023 •
edited

That's easy: https://v3.ocaml.org/p/core/v0.16.0/doc/Core/In_channel/index.html (searching Core.In_channel mod)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ildar @jrootham @bcc32 @github-iron @tdelvecchio-jsc