Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core_kernel still has some Unix references lurking #21

Closed
avsm opened this issue Sep 15, 2014 · 8 comments
Closed

Core_kernel still has some Unix references lurking #21

avsm opened this issue Sep 15, 2014 · 8 comments

Comments

@avsm
Copy link

avsm commented Sep 15, 2014

Notably:

lib/pooled_hashtbl.ml:      let unix_time_before = Unix.time () in

This forces the pack to depend on Unix even if only Core_kernel is linked. Most of the other references are just type-level (Unix.file_descr) and less bad since they dont introduce a cma/x dependency.

@bmillwood
Copy link
Contributor

This should be fixed in 112.06.

@raboof
Copy link

raboof commented Jun 10, 2015

Unfortunately this only lasted until 112.24.00 where Time_ns was introduced which calls Unix.localtime at some point. See #42

@yminsky
Copy link

yminsky commented Jun 11, 2015

Hmm. Seems like we need something internal in our build that prevents this from creeping back in.

@raboof
Copy link

raboof commented Jun 11, 2015

Agreed! I wonder if it'd help to try and convince oasis to use '-dontlink unix' when building the tests?

@hhugo
Copy link

hhugo commented Jun 11, 2015

We do have some internal check now. Wait for the next release.

async_kernel, bin_prot, core_kernel, fieldslib, sexplib, typerep_lib, variantslib
should all be free from Unix, Thread, Str references

@yminsky
Copy link

yminsky commented Jun 11, 2015

Lovely! Thanks.

@avsm
Copy link
Author

avsm commented Jun 11, 2015

Thanks Hugo!

@samoht
Copy link

samoht commented Jun 11, 2015

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants