Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _build to something else #10

Closed
rgrinberg opened this issue Feb 28, 2017 · 6 comments
Closed

Rename _build to something else #10

rgrinberg opened this issue Feb 28, 2017 · 6 comments

Comments

@rgrinberg
Copy link
Member

_build is the same name that ocamlbuild uses for running builds. Since a lot of the potential users of jbuilder might be migrating from ocamlbuild, avoiding this possible conflict might be helpful.

Also, it's not unthinkable that some people might want to use jbuilder and ocamlbuild in the same project. Might as well make it as easy as possible for them.

@ghost
Copy link

ghost commented Feb 28, 2017

This makes sense, although I quite like _build...

Possible alternatives:

  • .build
  • _jbuild
  • _artifacts

@rgrinberg
Copy link
Member Author

rgrinberg commented Mar 1, 2017

_jbuild is good. Will create a PR.

@samoht
Copy link
Member

samoht commented Mar 1, 2017

Why is this an issue to share the _build directory?

@ghost
Copy link

ghost commented Mar 1, 2017

I guess it might be a bit confusing if you forget to do a clean between runs of ocamlbuild and jbuilder. Otherwise I don't think there is a technical issue, except if there is a conflict between the files produced by jbuilder and ocamlbuild, for instance if you have a directory default at the root of your project.

@rgrinberg, can you think of something else?

@samoht
Copy link
Member

samoht commented Mar 1, 2017

I think it would be better to keep _build if possible. Mixed build systems in the same project is a very rare thing.

@ghost
Copy link

ghost commented Mar 1, 2017

I prefer that as well. I need to do another alpha release of jbuilder so that I can do another alpha release of Base, so I'm reverting the changes for now.

We can revisit this decision later if we experience problems with using _build or if there is a better consensus. At worse, ocamlbuild has a -build-dir option, and we could add one to jbuilder as well with a bit of refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants