Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guidelines for adding multi-file modules/libraries? #26

Closed
uvtc opened this issue Jan 25, 2021 · 6 comments
Closed

contribution guidelines for adding multi-file modules/libraries? #26

uvtc opened this issue Jan 25, 2021 · 6 comments

Comments

@uvtc
Copy link
Contributor

uvtc commented Jan 25, 2021

It looks to me like spork currently contains only single-file modules. However, some modules that may be a good fit for inclusion into spork may contain multiple files, their own tests, docs, etc. It is not clear how one would create a PR for inclusion of modules/libraries of this type. Would it make sense for there to be a contributions doc for this repository, specifically including guidelines for how to weave in these kinds of "larger" libraries?

@uvtc
Copy link
Contributor Author

uvtc commented Jan 25, 2021

One that came to mind is tomlin.

@uvtc
Copy link
Contributor Author

uvtc commented Jan 25, 2021

Or is spork better kept simple and for single-file modules?

@bakpakin
Copy link
Member

Currently, I think spork is best served by smaller, janet only modules. One reason for this is adding C modules means it may be harder to install in some platforms, but I'm not making a hard line here.

@pepe
Copy link
Member

pepe commented Jan 26, 2021

Thank you very much for the answer. I will link the answer to the spork discussion.

@pepe
Copy link
Member

pepe commented Jan 26, 2021

I guess we can close this, @uvtc.

@uvtc
Copy link
Contributor Author

uvtc commented Jan 26, 2021

Yup. Thanks.

@uvtc uvtc closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants