Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to suppress the SDK Warning #5

Closed
voshond opened this issue Jan 1, 2021 · 2 comments
Closed

ability to suppress the SDK Warning #5

voshond opened this issue Jan 1, 2021 · 2 comments

Comments

@voshond
Copy link

voshond commented Jan 1, 2021

Hi jang!

i've been using your package alot recently.
However i'm having the issue that Joystick Gremlin doesn't support the new fork of njx3, as i am using this vjoy device as an input.
I already opened a ticket for Joystick Gremlin, but seeing their backlog i don't think it will be implemented very soon.

Do you think we could add an option to disable the warning?

@jangxx
Copy link
Owner

jangxx commented Jan 1, 2021

I could move the check into the vJoyDevice constructor, so it would only show up when a new device is initialized (instead of when the library is require'd), and we could then have a disable_version_check parameter, which would suppress the warning.

But then again, is the warning really that annoying? If you are running different versions of the library and the driver, you are factually running an unsupported setup and I don't see why a little console message warning you of that fact could be that bad.

So basically: Yes, I could move some stuff around and add an option, but I'm not really convinced that it would add much to the library.

@jangxx
Copy link
Owner

jangxx commented Jan 20, 2021

Okay, I've now though of another way to disable the warning which is less invasive than what I thought up before. You simply have to set the environment variable DISABLE_VJOY_VERSION_CHECK to something, and you won't see the warning anymore. This feature is in version 1.2.2 which I've already published to npm and I think we can close this issue now.

@jangxx jangxx closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants