Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Http 5.0 #59

Closed
mgrunberg opened this issue May 26, 2021 · 1 comment
Closed

Support for Http 5.0 #59

mgrunberg opened this issue May 26, 2021 · 1 comment

Comments

@mgrunberg
Copy link
Contributor

Hi, I'm using Down::Http backend on a project. http 5.0.0 has been released a few days ago. I tried to upgrade the gem but I'm getting the following error:

Gem::LoadError: can't activate http (>= 2.1.0, < 5), already activated http-5.0.0. Make sure all dependencies are added to Gemfile.

Here is a script to reproduce the error.

require 'bundler/inline'

gemfile(true) do
  source 'https://rubygems.org'

  gem 'down', '~> 5.2'
  gem 'http', '~> 5.0'
end

require "down/http"

tempfile = Down::Http.download("https://www.google.com")
puts tempfile.path

The error is raised by a restriction on Down::Http backend.

I made PR #55 to allow version 5.x.

@janko
Copy link
Owner

janko commented May 27, 2021

#55 has been merged.

@janko janko closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants