Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file #7

Closed
jankrepl opened this issue Oct 10, 2020 · 5 comments
Closed

Add config file #7

jankrepl opened this issue Oct 10, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@jankrepl
Copy link
Owner

One could control things that are not controllable via CLI:

  • colors
@jankrepl jankrepl added the enhancement New feature or request label Oct 10, 2020
@AbhayAysola
Copy link
Contributor

  • Custom path for sample and ls could also be taken from config

@jankrepl
Copy link
Owner Author

jankrepl commented Nov 6, 2020

  • Custom path for sample and ls could also be taken from config

Very much related to #58.

@AbhayAysola I wonder what would be your usecase? I would imagine it is flexibility. The idea behind putting everything in ~/.mltype is to be able to run mlt ls and mlt sample from anywhere.

@AbhayAysola
Copy link
Contributor

That way, I could seperate models by folder to organise them well. Like Python related models in a Python folder, General English related go in English folder etc. When I want to use other models, I would just switch the path. The config file also wouldn't have to be manually updated, a command like mlt config could also work.

@AbhayAysola
Copy link
Contributor

  • default number of chars to generate
  • set key combination to exit

@jankrepl
Copy link
Owner Author

The config file logic was added in #89.
One can easily set defaults to all options for any of the commands of the CLI (e.g. number of characters)

Additionally, define any parameters inside of the general section then can be read anywhere within the code
mltype.utils.get_config_file. So there can be new pull requests using this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants