Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve onClick/onDoubleClick handling #107

Open
somekindadude opened this issue Jan 20, 2021 · 2 comments
Open

Improve onClick/onDoubleClick handling #107

somekindadude opened this issue Jan 20, 2021 · 2 comments

Comments

@somekindadude
Copy link
Contributor

There needs to be a way to stop propagation between the click events for item, avatar and rooms. E.g. when you click an avatar you don't click through to the room or the item. This makes it a little difficult to cancel walking or decide when to hide infostand elements when a blank space is clicked.

It would be better if there was a single event that fired rather than 3 events for each.

@jankuss
Copy link
Owner

jankuss commented Jan 21, 2021

I believe right now, a click on an avatar won't trigger the click on a furniture behind it.

The only thing not working correctly right now is the tile click when you click on Avatar/Furniture, since they are not using the same event manager. We should make it so they exist in the same event manager, so we can handle it accordingly.

@jankuss
Copy link
Owner

jankuss commented Feb 18, 2021

I believe there should be enough options with

  • event.stopPropagation()
  • event.skip()
  • event.skipExcept()

@somekindadude what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants