Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Faq - Dot notation #97

Closed
jasontorres opened this issue May 21, 2011 · 18 comments
Closed

Readme Faq - Dot notation #97

jasontorres opened this issue May 21, 2011 · 18 comments

Comments

@jasontorres
Copy link

dot notation is now supported. mustache/mustache#6 - but the FAQ said it doesn't. Confusing :)

Update: however, will mustache.js support it soon?

@Baggz
Copy link

Baggz commented Jun 1, 2011

+1

2 similar comments
@GCheung55
Copy link

+1

@sfsekaran
Copy link

+1

@honza
Copy link

honza commented Jun 26, 2011

  • 1

@sf-old
Copy link

sf-old commented Jun 26, 2011

+1

@GCheung55
Copy link

Looking into how this should be added, I've only gotten far as seeing https://github.com/janl/mustache.js/blob/master/mustache.js#L210 and trying to match it up with changes to mustache/mustache@73a8177

Is anyone else aware of dot notation having been implemented, just not git pulled?

@pvande
Copy link

pvande commented Jun 28, 2011

A spec-conforming implementation of dotted names requires a proper context stack; for a reasonably concise implementation of the feature, see https://github.com/pvande/Milk/blob/master/milk.coffee#L17.

@escobera
Copy link

escobera commented Aug 8, 2011

+1 for both specs and dot notation

@Radagaisus
Copy link

    1. going with the trend, i guess.

@zapnap
Copy link

zapnap commented Aug 22, 2011

+1 would love to see this...

@cj
Copy link

cj commented Aug 25, 2011

+1

4 similar comments
@raszi
Copy link

raszi commented Aug 31, 2011

+1

@esmevane
Copy link

+1

@NuckChorris
Copy link

+1

@mantoni
Copy link

mantoni commented Sep 25, 2011

+1

@janl
Copy link
Owner

janl commented Oct 11, 2011

Between issues, pull requests and private messages I remember a patch to be proposed that didn't have a test case. I can't find said discussion. If anyone proposes a good dot notation patch including a simple test case, I'm happy to add that to mustache.js.

@johnnypez
Copy link
Contributor

I've had a go at implementing support for this. Let's hope it gets in. #132

@janl
Copy link
Owner

janl commented Oct 20, 2011

Merged, thanks!

@janl janl closed this as completed Oct 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests