New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Argument.help_record
to get_help_record
+ fix typos
#116
Conversation
18969f5
to
5daa3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR! I'll merge this after making some changes.
@janluke Thank you, I appreciate that. |
…get_argument_help_record return types
Argument.help_record
to get_help_record
+ fix typos
@alexreg I had already reverted all changes I don't want to include but they were overwritten by your force-push. Sorry, I should have been clearer I would have made the changes. No need to change anything on your end! I'll just keep the method renaming and typo fixes. All other things will be reverted (sorry!), i.e. the return type of |
@janluke Oops, sorry about that. And yes, no worries. You kept most of the choices. Given our discussion, I agree it makes no sense to change the type signature (just the name, like you did). Not sure if you meant to change the formatting of imports, or whether it was just my formatter messing things up here, and it accidentally crept into the commit? This one, I mean. from typing import (Any, Callable, Dict, Iterable, List, NamedTuple, Optional,
Tuple, Type, TypeVar, cast, overload)
|
@alexreg No problem, fixed in master |
Argument.help_record
toArgument.get_help_record
, to bring the name into line withOption.get_help_record
(in Click).HandleNone
returned byArgument.get_help_record
.Handle case of empty sequence passed totext_rows
param ofHelpFormatter._get_row_sep_for
.Edited by @janluke