Aliases not added if Group is initialized with a list of commands

[ououmania]

Bug description
The subcommands' aliases are not added if a cloup.Group is instantiated directly with subcommands.

To Reproduce
The following snippet can be used to show the problem.

import cloup

@cloup.command(aliases=["t"])
def cmd():
    pass


cloup.Group("cli", show_subcommand_aliases=True, commands=[cmd])()

Save it in cloup_test.py and run the script. An error message will be printed.

Usage: cloup_test.py [OPTIONS] COMMAND [ARGS]...
Try 'cloup_test.py --help' for help.

Error: No such command 't'.

Possible solution
Init alias2name correctly in cloup.Group.init

def __init__(
  self, *args: Any, show_subcommand_aliases: Optional[bool] = None, **kwargs: Any
):
  super().__init__(*args, **kwargs)
  self.show_subcommand_aliases = show_subcommand_aliases
  self.alias2name: Dict[str, str] = {}

  # Add the following lines to initialize the alias dictionary.
  **for name, cmd in self.commands.items():
    for alias in getattr(cmd, 'aliases', []):
      self.alias2name[alias] = name**

[janluke]

Hi @ououmania, thanks for reporting. This looks like a bug, I'll look into it when I have time. Can you please file this issue as a bug and re-describe it in the following format to add clarity and ease my testing? You can leave your current snippet as proposed solution at the end of the issue. Always start a bug with a reproducible example. Thank you.

Bug description

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Delete this section if the expected behavior is obvious.

[ououmania]

Hi @ououmania, thanks for reporting. This looks like a bug, I'll look into it when I have time. Can you please file this issue as a bug and re-describe it in the following format to add clarity and ease my testing? You can leave your current snippet as proposed solution at the end of the issue. Always start a bug with a reproducible example. Thank you.

Bug description

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Delete this section if the expected behavior is obvious.

Thanks for your reply. Sure. I've updated the comment.