Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement option groups' and subcommand sections' support as mixins #2

Closed
janluke opened this issue Jan 8, 2021 · 1 comment
Closed

Implement option groups' and subcommand sections' support as mixins #2

janluke opened this issue Jan 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@janluke
Copy link
Owner

janluke commented Jan 8, 2021

Currently:

  • option groups' support is hard-coded into cloup.Command
  • subcommand sections' support is hard-coded into cloup.Group.

It may be useful to implement it as a mixin so that:

  • they can be more cleanly mixed with other click extensions
  • they can be mixed with multiple click command classes, e.g. cloup.Group could extend OptionGroupMixin.
@janluke janluke added the enhancement New feature or request label Jan 8, 2021
@janluke
Copy link
Owner Author

janluke commented Jan 16, 2021

Done, but I made the deliberate choice of not mixing OptionGroupMixin in cloup.Group. Groups should not have many options.

@janluke janluke closed this as completed Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janluke