Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Constraint.toggle_consistency_checks and related stuff with a Context setting #33

Closed
janluke opened this issue May 27, 2021 · 0 comments · Fixed by #34
Closed

Replace Constraint.toggle_consistency_checks and related stuff with a Context setting #33

janluke opened this issue May 27, 2021 · 0 comments · Fixed by #34
Labels
breaking change This breaks backward compatibility
Milestone
v0.9.0

Comments

@janluke
Copy link
Owner

janluke commented May 27, 2021 •
edited

Now that Cloup implements its own Context, there's no reason for using a class constant in Constraint. The following can be removed:

Constraint.__check_consistency
Constraint.toggle_consistency_checks()
Constraint.consistency_checks_toggled()

and replaced with Context.check_constraints_consistency
@janluke janluke added this to the v0.9.0 milestone May 27, 2021
@janluke janluke added the breaking change This breaks backward compatibility label May 27, 2021
@janluke janluke mentioned this issue May 27, 2021
Merged
@janluke janluke linked a pull request May 27, 2021 that will close this issue
Replace Constraint.__check_consistency and related methods with a Context setting #34
Merged
@janluke janluke closed this as completed May 27, 2021
@janluke janluke changed the title Replace Constraint.__check_consistency and related methods with a Context setting Replace Constraint.toggle_consistency_checks and related stuff with a Context setting Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This breaks backward compatibility
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Replace Constraint.__check_consistency and related methods with a Context setting janluke/cloup
1 participant
@janluke