Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install timezonefinder with numpy 2.0 #234

Closed
Gui-FernandesBR opened this issue Jun 16, 2024 · 3 comments · Fixed by #235
Closed

Can't install timezonefinder with numpy 2.0 #234

Gui-FernandesBR opened this issue Jun 16, 2024 · 3 comments · Fixed by #235
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@Gui-FernandesBR
Copy link

Hello,

numpy 2.0.0 was officially released today (https://pypi.org/project/numpy/)
However, the pyproject.toml file states numpy<2.0 as a dependency for timezonefinder.
I have successfully executed all the tests from the tests folder after updating numpy to 2.0.
It seems like this project doesn't really requires numpy <2.

Can we flexibilize the rules in the pyproject.toml file so timezonefinder can be installed with numpy 2.0?

There's a migration guide for numpy 2.0. The Python API changes are minimum:

@Gui-FernandesBR
Copy link
Author

@jannikmi if you need help I could open up a PR solving this issue.

As far as I understand, no modifications to the code source would be needed.

@jannikmi
Copy link
Owner

jannikmi commented Jun 17, 2024

Thanks for bringing this up.

@jannikmi
Copy link
Owner

I am on it.

@jannikmi jannikmi self-assigned this Jun 17, 2024
@jannikmi jannikmi added enhancement dependencies Pull requests that update a dependency file labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants