Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character image #9

Closed
9 tasks done
github-actions bot opened this issue Jun 28, 2020 · 0 comments · Fixed by #10
Closed
9 tasks done

Add character image #9

github-actions bot opened this issue Jun 28, 2020 · 0 comments · Fixed by #10
Labels

Comments

@github-actions
Copy link

github-actions bot commented Jun 28, 2020

Description

The visitors of your site already have a good impression of your character. It is even better to show your character visually. Therefore you should add a picture of your character. For that, you should choose a picture from the internet.

Tasks

Carry out the following steps:

  • Create a new branch named feature5_image
  • Check out this branch
  • Search on the search engine of your choice for a picture of your character that you particularly like. Make sure that the image license allows you to use it in private context. Now you need to get the direct link to this image. Get it by clicking on "Show file" or by right-clicking on the picture, "show graphic" and then copying the address from the address bar of your browser.
  • Paste the image at the bottom of your website using the HTML expression <img src="URL"/>. Replace the URL with the link to your image. The cheat sheets also shows a way to display images, but we want you to use this HTML expression.
  • Commit your changes and push them.
  • Create a pull request.
  • If both tests have passed, you can merge your changes into the master branch. If the tests fail, look at the comments of the pull request to find out what the problem was. Fix the errors so that the tests pass. A good idea is to repeat the steps of the issue again and see if everything is written correctly. You can also look at the Index.md file on GitHub and check the correct formatting. If you tried it for 15 minutes without success, you can have a look in the course forum.
  • Delete your feature branch. Switch to the master branch and update your local repository.
  • Take a look at your website and see if something has changed. You may have to update the page a few times.

If you have any questions, you can take a look at the course forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants