tx api: add address, type, value to vin. add fee. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this and, indeed it gives trx value and fee value that I needed. Would be nice to see this merged. Thanks for the help! |
dykstranet
reviewed
May 6, 2022
|
@janoside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the address, value and type information to vin for a transaction api results. This way the caller does not have to make multiple calls to get the vin information to get addresses and calculate the fee. I have calculated the fee and added it to the results as well.
This scenario came up when attempting to consume the tx API in my bitcoin-reports.com project.