Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node details page improvements #546

Merged

Conversation

Thierry61
Copy link
Contributor

@Thierry61 Thierry61 commented May 27, 2023

  • Corrected empty "HOST" field
  • Added a link from "PEERS" field to Peers page
  • Redefined forksUrls as a multiline variable (more readable)
  • Added tooltips

- Corrected empty "HOST" field
- Added a link from "PEERS" field to Peers page
- Redefine forksUrls page as a multiline variable (more readable)
- Added tooltips
@Thierry61
Copy link
Contributor Author

Hi @janoside. Are you not interested by the PR? I have been proposing these features for about 3 weeks, see #542 previous PR (I recreated a new PR because merge from upstream didn’t work as I expected):

  • Empty HOST field can be observed right now in your live demo:
    image
  • Linking peers page from PEERS field seems a right place to do it:
    image
  • Tooltips are a useful addition to this page. English is not my native tongue, so please correct them if you find better formulations (as "Allow edits by maintainers" is checked)

@janoside
Copy link
Owner

janoside commented Jun 8, 2023

@Thierry61 I like the PRs! Sorry for the delay. Recently finished up other obligations and coming back to merge PRs and try to get another release out ASAP.

@janoside janoside merged commit c3d3255 into janoside:master Jun 8, 2023
2 checks passed
@Thierry61 Thierry61 deleted the feature/node-details-improvements branch June 8, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants