pass custom query params to socket connection

[dakairus]

Hi guys,I been using this lib for a while, works awesome. I'm using it in a work project. Few days ago I got a request from my client that they want to use JWT, pass it into the socket connection query to validate into their server API.

I tried to set into de $sailsProvider the config.query value, but the query params that I added(a JSON with 3 different tokens) never reach the server, after a while reading how the library works I found this:

      if(!angular.isString(config.query)){
        config.query = sailsSdk.versionString();
      }else{
        config.query += '&'+sailsSdk.versionString();
      }

config.query if is not a string is overwritten with sailsSdk.versionString(), so I made a modification:

      if(!angular.isString(config.query)){
        var tmp = [];
        angular.forEach(config.query, function(value,key){
          tmp.push(key+'='+value);
        });
        var query = tmp.join('&');
        config.query = sailsSdk.versionString() + '&' + query;
      }else{
        config.query += '&'+sailsSdk.versionString()+ '&' + config.query;
      }

So in this way if the config.query is a JSON it appends the every key and value to the query.

Hope this help you guys.

[TheSharpieOne]

Per socket.io, the config's query must be a string, which is why it's limited to a string here. Yes, it would be nice to handle an object for the dev and turn it into a string (instead of making them do it before setting the value on config, which is the correct and intended use), but it is not as easy as that forEach. What is there are nested objects where value itself would be an object? Lucky, there is already a utility to sorta do this, but would need some adjustments to build the query string separate from the url.

[dakairus]

Hi, thx for the feedback. Well, yes is a problem if a nested JSON value is present, but is just the approach that I find by the moment, will be really nice have a option to build the url using the params.