-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML5 validation failures #33
Comments
Hi @dijitali, thank you for getting in touch 👋. http-equivThis might not be »valid«, but it's just a fun meta-tag we inherited from the original bearblog. See
The source code is here: https://github.com/HermanMartinus/bearblog/blob/master/templates/base.html#L5. ℹ️ Here's the story behind this non-standardised HTTP header: https://xclacksoverhead.org/home/about itempropThis one baffles me a little bit. We are using I went and checked what's up on the If you want to persue this further I'd suggest opening up an issue on the main Hugo repo, which includes the ➡️ Thus - I think - we'll just have to live with these errors on the validator (for now?). If you have a requirement for your personal website to be 100% valid against the w3c-validator you may overwrite the
templates locally. I hope that helps 🙏. Kind regards and have a good weekend 🏝. |
Thanks for such a considered response! Totally on board with you on both these points, I just hadn't realised how much was inherited by this repo. The first one would be ideal if it could be set as an actual HTTP response header but totally outside the scope of this and it looks like the second point has already been raised as a Hugo bug in gohugoio/hugo#7431. Hope you have a great weekend too! |
Just having a play with this theme (thanks for your work, it looks awesome!) and spotted a couple of minor things are currently being flagged by the W3C HTML Validator:
http-equiv
for any HTTP header, only those listed in the Pragma directives hereitemprop
attribute requires theitemscope
anditemtype
to be defined.I'm happy to pop some PRs up for these but I also wondered if you'd like the idea/would accept a PR to add a Github Action to automatically validate the build of the example site with the checker going forward?
The text was updated successfully, but these errors were encountered: