Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the case of using a quote inside a homepage article title #6

Closed
wants to merge 1 commit into from

Conversation

erwan-kessler
Copy link

This fix is only for the weird case that if you use a quote in the title like so

---
title: "You're the best"
weight: 30
header_menu: true
---

This in terms transform it to You're the best as a string which once evaluated by jquery gives the correct ID, thus the double escape

@janraasch janraasch closed this in f483bba Sep 7, 2020
@janraasch
Copy link
Collaborator

Hi @erwan-kessler, thank you very much for getting in touch ❤️ .

You are right; the implementation was error-prone.

In f483bba, I tried to move this logic away from the client.

Let me know, if this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants