-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to filter by tag #10
Comments
Hey @extmkv; thx for input. I like the idea and the resulting possibilities. |
They don't have the |
@jansauer I'm adding here the full curl request:
Tested and works fine. |
Also needed this improvement in the past would be fine to have this. |
any news @jansauer ? |
This enhancement is a must for multi-module-projects. Also both our mobile teams (iOS and Android) share the same set of localized strings and tagging is a way we plan to differentiate strings that are specific for each platform. I really hope this enhancement is included soon as to not resort to fastlane or similar scripts. You would make my work a lot easier if this is included and if weren't for a fact that I have never managed to correctly build a forked gradle project I would have added it my self.🙏 |
@extmkv I just noticed that you have forked this project. Have you managed to include this enhancement in your fork? |
Thank you so much @c-b-h ! |
@c-b-h I was checking and we're not sending the tags when creating the |
How would you, in the |
@extmkv ^^ |
@c-b-h Please take a look on the following screenshot So, it's possible to send also tags to the terms and everytime when we push the terms they will have the specific tags. |
I've created a PR to support tags on pushing terms #18 |
Currently, I'm using the gradle-poeditor-plugin in one of my android multi module project and in that project I've strings in several modules. In POEditor all strings have a specific tag, that tag is the name of the module where the string is inside.
So, I was checking the POEditor API 2.0 and in the export endpoint it's possible to filter by tag.
Example of the curl request:
So the ideia is to add a new field to the
trans
calledtags
:Example:
trans type: 'android_strings', file: 'library/src/main/res/values/strings.xml', tags:["library"]
The text was updated successfully, but these errors were encountered: