Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests #43

Closed
lucassus opened this issue Nov 16, 2016 · 3 comments
Closed

Broken tests #43

lucassus opened this issue Nov 16, 2016 · 3 comments

Comments

@lucassus
Copy link
Contributor

Since this commit webpack/webpack@2596b32 webpack uses different footer for generated files. It causes size mismatch in the comparator const compareOptions = {compareSize: true};
@lucassus
Copy link
Contributor Author

Other tests are failing because of "favicons": "^4.7.1" The latest version 4.8.x generated icons with more sizes

@jantimon
Copy link
Owner

Thanks for investigating 👍

@lucassus lucassus mentioned this issue Nov 16, 2016
Merged
@lucassus
Copy link
Contributor Author

Fixed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucassus @jantimon