Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.* default as filter excludes files in target folder #1

Closed
matthiasg opened this issue Jan 4, 2017 · 1 comment
Closed

*.* default as filter excludes files in target folder #1

matthiasg opened this issue Jan 4, 2017 · 1 comment

Comments

@matthiasg
Copy link

matthiasg commented Jan 4, 2017

Great addition to a webpack build pipeline! Works great. I especially like the way the HTMLPlugin is used to carry per file prefetch/preload options.

Two remarks:

Using *.* as default excludes files inside of e.g /dist folders. minimatch uses globbing so maybe it should default to '**/*.js' or similar. Or at least that might be mentioned in the README.

The name of the project might be better served having webpack in it. It seems to be a convention for many webpack plugins :)

@jantimon
Copy link
Owner

jantimon commented Jan 4, 2017

You are right with both points.

I changed the default to **/*.* and released it under the name resource-hints-webpack-plugin

@jantimon jantimon closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants