Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenScraper cookie support #31

Closed
1 of 5 tasks
jantman opened this issue Mar 29, 2017 · 0 comments
Closed
1 of 5 tasks

ScreenScraper cookie support #31

jantman opened this issue Mar 29, 2017 · 0 comments

Comments

@jantman
Copy link
Owner

jantman commented Mar 29, 2017

Support for loading and saving cookies from a cookie file is broken in PhantomJS 2.x (see ariya/phantomjs#13115 ). We need a workaround for this.

  • fix the ScreenScraper example in the docs to include actually getting a page - right now it's just doing Ajax stuff
  • instead of self.browser.get(), use a self.get_page() to allow some wrapping logic
  • make sure we're not calling browser close anywhere, or if we are, it's wrapped
  • every time we get a page, if the browser already had a page loaded, call get_cookies() and save them to disk.
  • When we first create the browser object, read the saved cookies from disk (if they exist) and pass them to the browser via add_cookie().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant