Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback plugin - Users without email breaking all of the backend part and backstage fully crashes #1709

Closed
jonatanask opened this issue May 23, 2024 · 1 comment
Assignees
Labels

Comments

@jonatanask
Copy link

jonatanask commented May 23, 2024

Describe the bug

https://github.com/janus-idp/backstage-plugins/tree/main/plugins/feedback#readme
https://github.com/janus-idp/backstage-plugins/tree/main/plugins/feedback-backend

When imported users from gitlab doesn't have emails because their accounts are private, the system fully crashes and backstage stops working

TypeError: Cannot read properties of undefined (reading 'email') at /app/node_modules/@janus-idp/backstage-plugin-feedback-backend/dist/cjs/plugin-DV3-jMW_.cjs.js:375:160 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Expected Behavior

If there is no email, just don't send email. Or possibility to not send emails and to not use jira, so possibility to just create feedbacks in database

What are the steps to reproduce this bug?

  1. When creating user kind, do not add email
apiVersion: backstage.io/v1alpha1
kind: User
metadata:
  name: guest
spec:
  memberOf: [guests]
  profile:
    displayName: Guest
  1. Create a feedback with guest user
@jonatanask jonatanask added kind/bug Something isn't working status/triage labels May 23, 2024
@github-actions github-actions bot added the jira label May 23, 2024
@jonatanask jonatanask changed the title Users without email breaking all of the backend part and backstage fully crashes CRITICAL CRASH - Users without email breaking all of the backend part and backstage fully crashes May 23, 2024
@jonatanask jonatanask changed the title CRITICAL CRASH - Users without email breaking all of the backend part and backstage fully crashes Feedback plugin - Users without email breaking all of the backend part and backstage fully crashes May 23, 2024
@jasperchui jasperchui removed the jira label May 27, 2024
@yashoswalyo yashoswalyo self-assigned this Jun 4, 2024
@yashoswalyo
Copy link
Member

yashoswalyo commented Jun 12, 2024

Fixed issue for user entities having no email property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants