This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
feat: Add BuildConfig option to build the image in cluster #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
force-pushed
the
in-cluster-build
branch
6 times, most recently
from
21dd999
to
e1a0cb9
Compare
|
@sabre1041 PTAL |
tumido
force-pushed
the
in-cluster-build
branch
2 times, most recently
from
92c1fac
to
cef00f5
Compare
sabre1041
suggested changes
Nov 18, 2022
tumido
changed the title
tumido
force-pushed
the
in-cluster-build
branch
3 times, most recently
from
704ed65
to
784f62a
Compare
tumido
changed the title
tumido
force-pushed
the
in-cluster-build
branch
2 times, most recently
from
9735d20
to
2fa9640
Compare
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow users to build images in local cluster instead of using a prepared image. Options are described in the README, along with a
values.yamlsample.Existing or Associated Issue(s)
Requires: janus-idp/redhat-backstage-build#3 and backstage/charts#78
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.