Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tag filtering mechanism to the plugin page #83

Closed
schultzp2020 opened this issue Jun 8, 2023 · 6 comments · Fixed by #90
Closed

Add a tag filtering mechanism to the plugin page #83

schultzp2020 opened this issue Jun 8, 2023 · 6 comments · Fixed by #90
Assignees

Comments

@schultzp2020
Copy link
Member

schultzp2020 commented Jun 8, 2023

Background

Currently the plugin page displays all plugins regardless of the plugin role specified in its package.json. e.g. 3scale-backend

Enhancement

  • Instead of using the role property, add a tags property in the plugin's package.json. This is because the role property is not easily understandable i.e. a custom action has a role of backend-plugin-module
  • Create a tag filtering mechanism based on the plugin role
  • Create a search bar based on the plugin name and tags
@serenamarie125
Copy link
Contributor

Acceptance Criteria:

  1. remove "Learn more" link
  2. make the description left aligned
  3. add tags to the bottom of the card, have them left-aligned

Tags should include:

  1. Frontend
  2. Backend
  3. Custom Actions

@gorkem
Copy link

gorkem commented Jun 8, 2023

One correction, If role refer to the backstage.role on package.json. We can not add tags instead of role but in addition to role. As backstage.role has significance to backstage build process.

@schultzp2020
Copy link
Member Author

One correction, If role refer to the backstage.role on package.json. We can not add tags instead of role but in addition to role. As backstage.role has significance to backstage build process.

Whoops, maybe I should've clarified that. I was not planning on removing the role property.

@tumido
Copy link
Member

tumido commented Jun 8, 2023

Updating with a chat convo on this:

@christophe-f:

We could just add the tag in the PLUGINS_LIST constant. That will avoid to syncup and read all the package.json files, and add website specific content into the plugins (edited)

@tumido:

That makes sense... and it's not like tags for a plugin are gonna change anyways...

@schultzp2020:

So should we add the tags here? https://github.com/janus-idp/janus-idp.github.io/blob/main/apps/website/content/plugin-list.js#L19-L27

@christophe-f:

yes that would be much easier.

@AayushSaini101
Copy link
Contributor

@schultzp2020 Can I work on this issue?

@schultzp2020
Copy link
Member Author

@AayushSaini101 sorry, there is already an existing pr to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants