Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text predicates (mostly negations) not supported by serializer #4275

Closed
FlorianHockmann opened this issue Feb 28, 2024 · 0 comments · Fixed by #4279
Closed

Some text predicates (mostly negations) not supported by serializer #4275

FlorianHockmann opened this issue Feb 28, 2024 · 0 comments · Fixed by #4279

Comments

@FlorianHockmann
Copy link
Member

#2559 added new text predicates, mostly negations of existing text predicates, but also textContainsPhrase as a completely new predicates. These added text predicates are however not supported by the JanusGraphPSerializer which is used for GraphSON and GraphBinary to serialize and deserialize JanusGraph predicates.

This means that it's not possible to use the new predicates with JanusGraph Server.

Please include configurations and logs if available.

For confirmed bugs, please report:

  • Version: 1.0.0
  • Storage Backend: any
  • Mixed Index Backend: any
  • Link to discussed bug: -
  • Expected Behavior: Predicates also working via JanusGraph Server
  • Current Behavior: Exception about missing support for the predicate (see below)
  • Steps to Reproduce: Trying to use added text predicates with JanusGraph Server

Stack Trace (if you have one)

This happens if I try to use one of the new predicates (textNotContains in this case) via JanusGraph Server:

Caused by: org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not deserialize the JSON value as required.
Nested exception: org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not deserialize the JSON value as required.
Nested exception: java.lang.UnsupportedOperationException: Matched predicate {textNotContains} is not support by JanusGraphPSerializer

I serialized it from JanusGraph.Net as I wanted to add support for these new predicates there until I realized that they aren't supported server side

FlorianHockmann added a commit to FlorianHockmann/janusgraph that referenced this issue Feb 28, 2024
The predicates added in JanusGraph#2559 were not supported by
`JanusGraphPSerializer` and could thus not be used when connecting via
remote to JanusGraph Server.

Fixes JanusGraph#4275

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann added a commit that referenced this issue Mar 4, 2024
The predicates added in #2559 were not supported by
`JanusGraphPSerializer` and could thus not be used when connecting via
remote to JanusGraph Server.

Fixes #4275

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
janusgraph-automations pushed a commit that referenced this issue Mar 4, 2024
The predicates added in #2559 were not supported by
`JanusGraphPSerializer` and could thus not be used when connecting via
remote to JanusGraph Server.

Fixes #4275

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
(cherry picked from commit 5b906fe)
FlorianHockmann added a commit that referenced this issue Mar 5, 2024
The predicates added in #2559 were not supported by
`JanusGraphPSerializer` and could thus not be used when connecting via
remote to JanusGraph Server.

Fixes #4275

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
(cherry picked from commit 5b906fe)
@FlorianHockmann FlorianHockmann added this to the Release v1.1.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant