Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot result does not fit preview #5

Closed
kossoj opened this issue Jan 25, 2024 · 5 comments
Closed

Snapshot result does not fit preview #5

kossoj opened this issue Jan 25, 2024 · 5 comments

Comments

@kossoj
Copy link

kossoj commented Jan 25, 2024

There is still an issue with snapshot results on Android. It looks like the line to fix it is commented out. See the original issue: hjam40#98

@janusw
Copy link
Owner

janusw commented Jan 31, 2024

There is still an issue with snapshot results on Android. It looks like the line to fix it is commented out.

Which line are you talking about?

@kossoj
Copy link
Author

kossoj commented Feb 1, 2024

A line has been commented out in TakeSnap method.
line
But I can just see that it is different from the proposal:
bitmap = Bitmap.CreateBitmap(bitmap, (bitmap.Width - Width)/2, (bitmap.Height - Height) / 2, Width, Height);

@aleksandervalle
Copy link

hjam40#132

@janusw
Copy link
Owner

janusw commented Feb 8, 2024

hjam40#132

I have cherry-picked this fix into my master branch now. The CI (GIthub Actions) automatically builds a nupkg that you can use, and I hope to tag another release soon.

@janusw
Copy link
Owner

janusw commented Feb 22, 2024

Fixed with release 1.4.7:
https://github.com/janusw/Camera.Maui/releases/tag/1.4.7

@janusw janusw closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants