You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First things first, I love the new version, this package is headed in the right direction and look forward to it getting even better!
I'm working on my own version of the Vow test runner for AdonisJS since it hasn't been ported over for version 5.
I would like to have the freedom to build on top of the Japa classes by extending them on my own custom classes.
Problem is that most of methods and properties are private instead of protected, so they can't be overridden or accessed, even when they are extended.
It makes the custom classes unwieldy trying to find ways around that with a bunch of extra clutter.
Since the idea of Japa is to build on top of it, it would make sense for the class to be extendible with the methods and properties available for the developer to override and access.
Of course, there's a time and place for private methods and properties, but closer to the end user.
Thanks!
The text was updated successfully, but these errors were encountered:
mikesaintsg
changed the title
Private methods and properties changed to Protected to extends
Change Private methods and properties to Protected to use Japa classes as Base classes
Feb 7, 2022
Version 5.0.17-0
First things first, I love the new version, this package is headed in the right direction and look forward to it getting even better!
I'm working on my own version of the Vow test runner for AdonisJS since it hasn't been ported over for version 5.
I would like to have the freedom to build on top of the Japa classes by extending them on my own custom classes.
Problem is that most of methods and properties are private instead of protected, so they can't be overridden or accessed, even when they are extended.
It makes the custom classes unwieldy trying to find ways around that with a bunch of extra clutter.
Since the idea of Japa is to build on top of it, it would make sense for the class to be extendible with the methods and properties available for the developer to override and access.
Of course, there's a time and place for private methods and properties, but closer to the end user.
Thanks!
The text was updated successfully, but these errors were encountered: