Should setup group-hook inject stuff into test context

[brkn]

Description

I've tried injecting stuff into the test context and it worked. But this is not documented, is this a bad pattern?

test.group("foo endpoint", (group) => {
  group.each.setup(async (test) => {
    const drive = Drive.fake("gcs");

    // @ts-ignore
    test.context.drive = drive;

    return () => Drive.restoreAll();
  });

  test("mocked disk test", async ({ test: { context } }) => {
    // @ts-ignore
    console.log(context.drive); // 👈prints actually
  });
});

Alternative is getting the instance in the test scope but restoring everything at the teardown, I guess. But it feels weird to copy paste drive mocking setup in each test.

test.group("foo endpoint", (group) => {
  group.each.teardown(async (test) => {
    Drive.restoreAll();
  });

  test("mocked disk test", async ({ test: { context } }) => {
    const drive = Drive.fake("gcs");
	
	// send request here

	// assertions
	assert.equal(await drive.get('package.json'), JSON.stringify({}))

	// let the teardown hook do the cleanup
  });
});

Package version

v2.0.7

[thetutlage]

Since the APIs allows you to inject custom properties in the context, you can do that. Yes, it is not documented, because not everything can be captured in documentation and a lot of stuff is about experimenting and building custom flows around the public APIs.

I guess. But it feels weird to copy paste drive mocking setup in each test.

It depends on how you like to code. I am personally okay with copy/pasting code within multiple tests and do not try to remove every duplicate line of code. Dan Abramov (maintainer of React) wrote a great article on the same https://overreacted.io/the-wet-codebase/.

I will close the issue as there is nothing actionable here 👍